1. Forum
  2. DOVE-Net
  3. Synchronet Programming

  • src/sbbs3/postmsg.cpp

    From Rob Swindell@VERT to Git commit to main/sbbs/master on Thu Mar 18 21:24:40 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/54c935707ff58e948fb0df2b
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Move the tags prompt to *before* the locking of the message base

    Thanks Mr. Executive Chicken esq. for the telephone call and bug report.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Sun Apr 4 15:13:57 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/489267ade424d4f40cf8b752
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    mod_ar is no longer a pointer, it's an array

    CID 319077

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Tue Apr 13 20:20:22 2021
    https://gitlab.synchro.net/main/sbbs/-/commit/908618c85f29a300acc7a500
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Debug the "thread_back field missing" error

    Some QWKnet vote messages are failing:
    evnt unpackREP <ENSEMBLE> !ERROR 2 (No such file or directory) in qwk.cpp line 1146 (qwk_vote) writing "/sbbs/data/subs/dove-gen" access=-105 info=smb_addvote thread_back field missing

    Catch this problem a little higher up (in votemsg()) and log the message's reply-IDs to help determine what's the root-cause here. Don't bother calling smb_addvote() if thread_back is 0.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to main/sbbs/master on Mon Oct 24 15:49:30 2022
    https://gitlab.synchro.net/main/sbbs/-/commit/33a8b69cfbbd8194e3519608
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Strip control chars/ctrl-A sequences from msg subject in notify()

    We may want Ctrl-A sequences in the telegram subject, but not in the message subject

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Wed Apr 22 23:25:08 2020
    src/sbbs3 postmsg.cpp 1.131 1.132
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv26315

    Modified Files:
    postmsg.cpp
    Log Message:
    Don't try to signal an empty semaphore path if the netmail_sem is blank.


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From rswindell@VERT to CVS commit on Sun May 24 17:41:52 2020
    src/sbbs3 postmsg.cpp 1.132 1.133
    Update of /cvsroot/sbbs/src/sbbs3
    In directory cvs:/tmp/cvs-serv27907

    Modified Files:
    postmsg.cpp
    Log Message:
    Include a replied-to message's to field to be selected in the post-to history (arrow-up to choose strings from history).


    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wed Sep 30 21:25:17 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/97bade44ebad5b431485e93c
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Notify local recipients of locally-posted messages addressed to them.

    While SBBSecho would notify local users of imported messages addressed to
    them (both EchoMail and NetMail) and QWK-imported messages recently gained
    the ability to notify local recipients of messages addressed to them, other methods of posting messages (e.g. just using the normal terminal server
    method, e.g. the 'P' command) or using any JavaScript (e.g. web) methods of posting messages lacked recipient notifications. So that's now fixed.
    And for JavaScript-saved local email messages too. I don't *think* this will result in any duplicate notifications of received messages, but let me know
    if you see excess/duplicate notifications.
    Anonymously posted messages are excluded.
    Messages posted to yourself are excluded (who does that?).

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wed Sep 30 21:26:58 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/f4ac7f3920abba7d3c717e3d
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Resolve a gcc warning about signedness.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Sat Oct 3 12:16:52 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/c8193766c6b75abb18a2c257
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Fix savemsg() bug introduced in 97bade44eb (Sep-30), returning false failure

    'i' is the return value of savemg(), used to determine success or failure
    (and what kind of failure) - so we can't use that for the usernumber of
    the recipient.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell@VERT to Git commit to sbbs/master on Wed Nov 11 17:55:49 2020
    https://gitlab.synchro.net/sbbs/sbbs/-/commit/a852cced25cbf1285825942f
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Reduce unnecessary posted-to username searches. Auto-UTF8 in savemsg().

    When posting to "All" or replying to a message that was posted by networked (not local) user, don't attempt to search for that username in the local user base to inform them of the posted message to them.

    savemsg() is the underlying C function for saving a new message (mail or post) to a message base from several places, including JS modules. If there was no "charset" specified in the passed message header, check to see if the message body text is non-ASCII but valid UTF-8, and if it is, set the FIDO_CHARSET header field to the appropriate UTF-8 charset identifier string. This would *also* address Issue #177 reported by Michael J. Ryan. It's possible, but unlikely, that a message text would contain valid CP437 that *also* happened to be valid UTF-8. If that does happen to occur (e.g. in posted ANSI art?), we might want to revert this enhancement to savemsg() and leave to the caller's to detect/specify the charset, always.

    ---
    ï¿­ Synchronet ï¿­ Vertrauen ï¿­ Home of Synchronet ï¿­ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows)@VERT to Git commit to main/sbbs/master on Sun May 7 23:22:44 2023
    https://gitlab.synchro.net/main/sbbs/-/commit/4a86ab8768e486a58d22d55e
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    Bounds-check subnum in savemsg()

    It's possible to use savemsg() (from JS MsgBase.save_msg()) to add a message
    to a message base that's not a sub-board (not configured in SCFG->Message
    Areas and not the "mail" base), but in that case, savemsg() would dereference an invalid sub in the scfg->sub array and crash. So use is_valid_subum()
    to insure the subnum is a valid sub before using as an index.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net
  • From Rob Swindell (on Windows 11)@VERT to Git commit to main/sbbs/master on Mon Dec 9 19:15:31 2024
    https://gitlab.synchro.net/main/sbbs/-/commit/69111a8f420d212de3c0d638
    Modified Files:
    src/sbbs3/postmsg.cpp
    Log Message:
    If user doesn't modify the replied-to-msg subject, use the original subject

    (which might be UTF-8 encoded). This works-around the problem that Accession reported in #synchronet with my reply to a UTF-8 encoded message using a CP437 terminal which resulted in a message body that was UTF-8 encoded but a message subject that was CP437 encoded. This mix of encodings is not supported by FTN standards.

    This is just a work-around since if the user modifies the subject the result could still have the CP437 unside-down question marks (indicating non-translatable UNICODE chars) and those should be converted to UTF-8
    chars when going out on FTN or being stored in the message base. So there's still a bug here somewhere that I need to look into more.

    ---
    þ Synchronet þ Vertrauen þ Home of Synchronet þ [vert/cvs/bbs].synchro.net